Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-6268] returns NaN insteadof nan #7498

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

3axap4eHko
Copy link
Contributor

@3axap4eHko 3axap4eHko commented Aug 31, 2022

Fixes ISSUE-6268

@google-cla
Copy link

google-cla bot commented Aug 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema javascript typescript labels Aug 31, 2022
@3axap4eHko 3axap4eHko changed the title [] returns NaN insteadof nan [ISSUE-6268] returns NaN insteadof nan Aug 31, 2022
@dbaileychess
Copy link
Collaborator

@bjornharrtell PTAL

@bjornharrtell
Copy link
Collaborator

Seems correct to me.

@dbaileychess dbaileychess merged commit 5634dc3 into google:master Aug 31, 2022
@dbaileychess
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema javascript typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatc converts NaN to nan when compiling for javascript
3 participants