Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake]: fix breaking find_package change (#7499) #7502

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

clanghans
Copy link
Contributor

Addresses (#7499) and fixes breaking changes introduced with (#7323).

find_package config module is changed to lowercase as well as the config version file. This allows for find_package(Flatbuffers CONFIG)

@dbaileychess
Copy link
Collaborator

Is there a reference for this case-insensitive lookup?

@dbaileychess
Copy link
Collaborator

The command searches for a file called <name>Config.cmake or <lower-case-name>-config.cmake for each name specified

https://cmake.org/cmake/help/v3.3/command/find_package.html

dbaileychess
dbaileychess previously approved these changes Aug 31, 2022
@dbaileychess dbaileychess merged commit d465b39 into google:master Sep 1, 2022
mtrofin added a commit to google/ml-compiler-opt that referenced this pull request Sep 12, 2023
After google/flatbuffers#7502, it's
`FlatBuffers`. This was reflected in the tensorflow repo, for tflite, in tensorflow/tensorflow#61399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants