Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves swift package to root of repository so it can be used directly … #7548

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

mustiikhalil
Copy link
Collaborator

Moves swift packages to root directory, so it can be used directly from the main repository instead of it being maintained somewhere else

@keith since you added Bazel, would love to know if this change will affect it

@keith
Copy link
Contributor

keith commented Sep 26, 2022

It shouldn't! Since you didn't move the swift files themselves the glob in the BUILD file is still valid

@mustiikhalil
Copy link
Collaborator Author

@dbaileychess what do you think? do we move those three files to the root, and simply use this repository as the main repo, for the swift liib? or keep it as is?
Personally i don't have any issues.

@dbaileychess
Copy link
Collaborator

@mustiikhalil Yeah, if it is only a few files like those, that is fine.

…from the main repo

Fixing paths for swift directory
@mustiikhalil mustiikhalil marked this pull request as ready for review September 27, 2022 21:07
@mustiikhalil
Copy link
Collaborator Author

If that's the case, this is ready to be merged

@dbaileychess
Copy link
Collaborator

Great, mind updating https://github.com/google/flatbuffers/wiki/FlatBuffers-release-process for swift?

@dbaileychess dbaileychess merged commit dadbff5 into google:master Sep 27, 2022
@mustiikhalil
Copy link
Collaborator Author

Great, mind updating https://github.com/google/flatbuffers/wiki/FlatBuffers-release-process for swift?

Done

@mustiikhalil mustiikhalil deleted the mmk/moved-swift-packages branch November 27, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants