Unify normalization layers#1545
Merged
Merged
Conversation
Contributor
jheek
commented
Sep 16, 2021
jheek
commented
- Refactor normalization helpers to share code and remove subtle differences in implemenation.
- Use clipping to avoid negative variances due to fusion optimization.
- Refactor normalization helpers to share code and remove subtle differences in implemenation. - Use clipping to avoid negative variances due to fusion optimization.
jheek
force-pushed
the
unified-normalization
branch
from
b3bace1 to
80c91a0
Compare
levskaya
approved these changes
Sep 17, 2021
Collaborator
levskaya
left a comment
levskaya
left a comment
There was a problem hiding this comment.
This is great, thanks for unifying all this.
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 82.73% 82.81% +0.08%
==========================================
Files 68 68
Lines 5572 5576 +4
==========================================
+ Hits 4610 4618 +8
+ Misses 962 958 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.