Skip to content

Commit

Permalink
Fix the contributing doc to be more direct about how contributions ar…
Browse files Browse the repository at this point in the history
…e accepted.

PiperOrigin-RevId: 268465038
  • Loading branch information
mehmetf authored and jamesderlin committed Sep 11, 2019
1 parent ee166fc commit 1cb717b
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions CONTRIBUTING.md
Expand Up @@ -38,6 +38,12 @@ Please peruse Flutter's
working on anything non-trivial. These guidelines are intended to
keep the code consistent and avoid common pitfalls.

You must complete the
[Contributor License Agreement](https://cla.developers.google.com/clas). You can
do this online, and it only takes a minute. If you've never submitted code
before, you must add your (or your organization's) name and contact info to the
[AUTHORS](AUTHORS) file.

To start working on a patch:

* `git fetch upstream`
Expand All @@ -54,14 +60,11 @@ To send us a pull request:

Please make sure all your checkins have detailed commit messages explaining the patch.

Once you've gotten an LGTM from a project maintainer and once your PR has received
the green light from all our automated testing (Travis, Appveyor, etc), one of the
project maintainers will merge the changes using a tool to sync with our internal
flutter widgets repo. The PR will automatically be closed when the changes are
merged externally.
Once you've gotten an LGTM from a project maintainer and once your PR has
received the green light from all our automated testing (Travis, Appveyor, etc),
one of the project maintainers will merge the changes to our internal repo. This
might cause test failures that need to be debugged internally so we might make
further suggestions on your PR.

You must complete the
[Contributor License Agreement](https://cla.developers.google.com/clas).
You can do this online, and it only takes a minute.
If you've never submitted code before, you must add your (or your
organization's) name and contact info to the [AUTHORS](AUTHORS) file.
Once the internal change is submitted to the private repo, we will run our sync
scripts to bring this repo up to date. At that point, your PR will be closed.

0 comments on commit 1cb717b

Please sign in to comment.