New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merriweather cyrillic uppercase Ы letter #588

Closed
vladshcherbin opened this Issue Jan 22, 2017 · 20 comments

Comments

Projects
None yet
6 participants
@vladshcherbin

vladshcherbin commented Jan 22, 2017

Chrome
Mac os sierra 10.12.2

Google fonts website, lowecase letter ы is okay, uppercase Ы is not.

screen shot 2017-01-22 at 11 11 51 am

@m4rc1e m4rc1e self-assigned this Jan 23, 2017

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Jan 23, 2017

Collaborator

@vladshcherbin which browser?

Collaborator

m4rc1e commented Jan 23, 2017

@vladshcherbin which browser?

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Jan 23, 2017

@m4rc1e google chrome 54.0.2840.98

vladshcherbin commented Jan 23, 2017

@m4rc1e google chrome 54.0.2840.98

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Jan 23, 2017

same with Safari - Version 10.0.2 (12602.3.12.0.1)
and Firefox - 45.0.2

vladshcherbin commented Jan 23, 2017

same with Safari - Version 10.0.2 (12602.3.12.0.1)
and Firefox - 45.0.2

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Jan 23, 2017

Collaborator

@vladshcherbin confirmed.

I'll investigate this now.

screen shot 2017-01-23 at 11 06 58

Collaborator

m4rc1e commented Jan 23, 2017

@vladshcherbin confirmed.

I'll investigate this now.

screen shot 2017-01-23 at 11 06 58

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Jan 23, 2017

Collaborator

@vladshcherbin I can confirm we've fixed this in a pull request, #37 sent to the upstream repo

As soon as @EbenSorkin merges this, I will pr it here.

screen shot 2017-01-23 at 11 10 21

Cheers,
Marc

Collaborator

m4rc1e commented Jan 23, 2017

@vladshcherbin I can confirm we've fixed this in a pull request, #37 sent to the upstream repo

As soon as @EbenSorkin merges this, I will pr it here.

screen shot 2017-01-23 at 11 10 21

Cheers,
Marc

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Jan 23, 2017

@m4rc1e great, thank you 👍

vladshcherbin commented Jan 23, 2017

@m4rc1e great, thank you 👍

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Jan 23, 2017

Collaborator

@alexeiva do we have any idea what caused this?

Collaborator

m4rc1e commented Jan 23, 2017

@alexeiva do we have any idea what caused this?

@alexeiva

This comment has been minimized.

Show comment
Hide comment
@alexeiva

alexeiva Jan 24, 2017

Collaborator

This is an old bug. Ы was made from two components Ь + I and the they got reordered during export to UFO (from FontLab). Anyway I don't recommend using components for Ы, since the left Ь-part is generally compensated in width than proper Ь.

This is similar to how component-made fractions collaps when you open a UFO in Glyphs App.

Collaborator

alexeiva commented Jan 24, 2017

This is an old bug. Ы was made from two components Ь + I and the they got reordered during export to UFO (from FontLab). Anyway I don't recommend using components for Ы, since the left Ь-part is generally compensated in width than proper Ь.

This is similar to how component-made fractions collaps when you open a UFO in Glyphs App.

@davelab6

This comment has been minimized.

Show comment
Hide comment
@davelab6

davelab6 Jan 31, 2017

Member

@vladshcherbin confirmed fixed on fonts.google.com so closing:

screen shot 2017-01-30 at 19 51 34

@alexeiva thanks for explaining :)

Member

davelab6 commented Jan 31, 2017

@vladshcherbin confirmed fixed on fonts.google.com so closing:

screen shot 2017-01-30 at 19 51 34

@alexeiva thanks for explaining :)

@davelab6 davelab6 added this to the Bugs in Font Files Requiring Rebuild milestone Jan 31, 2017

@davelab6 davelab6 closed this Feb 2, 2017

@a-rusak

This comment has been minimized.

Show comment
Hide comment
@a-rusak

a-rusak Mar 22, 2017

Any updates? The issue still exist:
image

a-rusak commented Mar 22, 2017

Any updates? The issue still exist:
image

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Mar 22, 2017

Can confirm, issue is back:

screen shot 2017-03-22 at 3 11 09 pm

vladshcherbin commented Mar 22, 2017

Can confirm, issue is back:

screen shot 2017-03-22 at 3 11 09 pm

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Apr 4, 2017

@davelab6 , @m4rc1e reopen this, the bug is not fixed for so long. Can't even imagine, how bad it
looks on cyrillic sites, using this font 😱

vladshcherbin commented Apr 4, 2017

@davelab6 , @m4rc1e reopen this, the bug is not fixed for so long. Can't even imagine, how bad it
looks on cyrillic sites, using this font 😱

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Apr 4, 2017

Collaborator

@vladshcherbin we had to revert the fonts from v2.000 back to v1.584 due to regression issues, a few months back.

@davelab6 Shall I hotfix this old version, while Eben continues to fix the regression issues in v2.000?

Collaborator

m4rc1e commented Apr 4, 2017

@vladshcherbin we had to revert the fonts from v2.000 back to v1.584 due to regression issues, a few months back.

@davelab6 Shall I hotfix this old version, while Eben continues to fix the regression issues in v2.000?

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Apr 4, 2017

@m4rc1e I appreciate your work, guys, but reverting the font and letting such a huge bug to exist for months, knowing about it and not fixing...

The users (me too), who are using Google Fonts, expect it to be tested and reliable as millions of sites are using Google Fonts every day. Such bugs in production... I really don't understand this, sorry.

vladshcherbin commented Apr 4, 2017

@m4rc1e I appreciate your work, guys, but reverting the font and letting such a huge bug to exist for months, knowing about it and not fixing...

The users (me too), who are using Google Fonts, expect it to be tested and reliable as millions of sites are using Google Fonts every day. Such bugs in production... I really don't understand this, sorry.

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Apr 4, 2017

Collaborator

@vladshcherbin the revert was necessary because of a far larger issue, EbenSorkin/Merriweather#41. This was the lesser of two evils I'm afraid.

Our QA tools have been improving for the past few months. It's difficult to spot such errors because they do not violate any technical specifications. It has to be done visually. We now have regression tools which will show if glyphs have changed too drastically since the previous release. Again, this needs to be checked by eye.

Collaborator

m4rc1e commented Apr 4, 2017

@vladshcherbin the revert was necessary because of a far larger issue, EbenSorkin/Merriweather#41. This was the lesser of two evils I'm afraid.

Our QA tools have been improving for the past few months. It's difficult to spot such errors because they do not violate any technical specifications. It has to be done visually. We now have regression tools which will show if glyphs have changed too drastically since the previous release. Again, this needs to be checked by eye.

@m4rc1e m4rc1e reopened this Apr 4, 2017

@m4rc1e

This comment has been minimized.

Show comment
Hide comment
@m4rc1e

m4rc1e Apr 4, 2017

Collaborator

@vladshcherbin I've reopened this.

Collaborator

m4rc1e commented Apr 4, 2017

@vladshcherbin I've reopened this.

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Apr 4, 2017

@m4rc1e I'm not an expert in fonts, just a regular developer.

You knew about this bug when reverted the font version and @a-rusak mentioned it again 2 weeks ago. As a website owner, I would be very upset if all my headings (and all uppercase words) would have a wrong letter. I'm just upset of seeing this happen in such a big trusted company.

Anyway, I really hope it will be fixed as soon as possible. Thanks.

vladshcherbin commented Apr 4, 2017

@m4rc1e I'm not an expert in fonts, just a regular developer.

You knew about this bug when reverted the font version and @a-rusak mentioned it again 2 weeks ago. As a website owner, I would be very upset if all my headings (and all uppercase words) would have a wrong letter. I'm just upset of seeing this happen in such a big trusted company.

Anyway, I really hope it will be fixed as soon as possible. Thanks.

m4rc1e added a commit to m4rc1e/fonts that referenced this issue Apr 24, 2017

m4rc1e added a commit to m4rc1e/Merriweather that referenced this issue Apr 24, 2017

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Jul 2, 2017

3 months later still not fixed, half year bug in all cyrillic websites. Definitely won't use google fonts again and won't recommend it to anyone.

Simply wow.

vladshcherbin commented Jul 2, 2017

3 months later still not fixed, half year bug in all cyrillic websites. Definitely won't use google fonts again and won't recommend it to anyone.

Simply wow.

@davelab6 davelab6 closed this in #736 Aug 7, 2017

davelab6 added a commit that referenced this issue Aug 7, 2017

@vladshcherbin

This comment has been minimized.

Show comment
Hide comment
@vladshcherbin

vladshcherbin Aug 9, 2017

Even though this issue is closed, the bug is still not fixed which is no surprise.

screen shot 2017-08-09 at 4 07 17 pm

vladshcherbin commented Aug 9, 2017

Even though this issue is closed, the bug is still not fixed which is no surprise.

screen shot 2017-08-09 at 4 07 17 pm

@EbenSorkin

This comment has been minimized.

Show comment
Hide comment
@EbenSorkin

EbenSorkin Aug 9, 2017

EbenSorkin commented Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment