Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playpen Sans: Version 1.000 added #6673

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

vv-monsalve
Copy link
Collaborator

896f02c: [gftools-packager] Playpen Sans: Version 1.000 added

@github-actions

This comment was marked as outdated.

@RosaWagner RosaWagner linked an issue Sep 7, 2023 that may be closed by this pull request
6 tasks
@vv-monsalve
Copy link
Collaborator Author

Updated

Playpen Sans: Version 1.000 added


7a961d9: [gftools-packager] Playpen Sans: Version 1.000 added

@vv-monsalve vv-monsalve force-pushed the gftools_packager_ofl_playpensans branch from 896f02c to 7a961d9 Compare September 7, 2023 16:08
@github-actions

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator Author

Before merging, we await confirmation on the order in which the designers should appear + biographical information.

@vv-monsalve
Copy link
Collaborator Author

@RosaWagner I was still creating the PR and I was about to add the related issue before you did it.

@RosaWagner
Copy link
Contributor

Call me Flash-rosie

@vv-monsalve
Copy link
Collaborator Author

All right, everything is set up now 😎

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[16] PlaypenSans[wght].ttf
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, tifinagh, math

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, math, tifinagh, canadian-aboriginal, old-permic, coptic, syriac, malayalam

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    23 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.51x (1510) [code: bad-hhea-range]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Laura Meseguer is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that José Scaglione is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Check if category on METADATA.pb matches what can be inferred from the family name. (com.google.fonts/check/metadata/category_hints)
  • WARN Familyname seems to hint at "SANS_SERIF" but METADATA.pb declares it as "['HANDWRITING']". [code: inferred-category]
WARN: Check if uppercase glyphs are vertically centered. (com.google.fonts/check/caps_vertically_centered)
  • WARN Uppercase glyphs are not vertically centered in the em box. [code: vertical-metrics-not-centered]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋ į̛̌ į̛̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Belarusian (Cyrl, 10,064,517 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/playpensans/PlaypenSans[wght].ttf
Dehinted Size 508.2kb
Hinted Size 508.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/playpensans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 8 49 9 183 0
0% 0% 3% 20% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 06bda5e into main Sep 8, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_playpensans branch September 8, 2023 14:20
@RosaWagner RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Sep 21, 2023
@RosaWagner
Copy link
Contributor

Blocking this until the subset is merge internally (cf googlefonts/glyphsets#127), and should then be repushed to_sandbox.

@chrissimpkins
Copy link
Collaborator

@RosaWagner @vv-monsalve OK to push a new PR with the updated subsetter definitions in METADATA.pb, merge, and push to sandbox. Nate updated the subsetter defs yesterday.

@RosaWagner RosaWagner removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Playpen Sans
3 participants