Skip to content

The %C and %Q will not detected when eot_line = "other string" #283

@ljcucc

Description

@ljcucc

When eot_line set to other string, then %C and %Q will not detected.

for example:

./gemma \                                                                                                                                          
    --tokenizer./tokenizer.spm \
    --model 9b-it  \
    --compressed_weights ./9b-it-sfp.sbs  \
    --multiturn 1 \
    --eot_line .

reference:

if (prompt_string == "%c" || prompt_string == "%C") {

at Line 129, the %C and %Q only detect prompt_string, but this will fail when eot_line set to something else.

Metadata

Metadata

Labels

type:bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions