Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations #123

Merged
merged 1 commit into from Oct 19, 2016

Conversation

@yying
Copy link
Contributor

@yying yying commented Sep 15, 2016

LogDestination::DeleteLogDestinations deletes sinks_ but does not set the global to NULL.

Further calls to LogDestination::AddLogSink will incorrectly use the stale sinks_ pointer and potentially crash (https://github.com/google/glog/blob/master/src/logging.cc#L621).

This simple fix sets sinks_ to NULL after the sinks_ is deleted.

@googlebot
Copy link
Collaborator

@googlebot googlebot commented Sep 15, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@googlebot googlebot added the cla: no label Sep 15, 2016
@yying
Copy link
Contributor Author

@yying yying commented Sep 15, 2016

I signed it!

@googlebot
Copy link
Collaborator

@googlebot googlebot commented Sep 15, 2016

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 15, 2016
@ukai ukai merged commit bf766fa into google:master Oct 19, 2016
1 check passed
1 check passed
cla/google All necessary CLAs are signed
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.