Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations #123
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
bf766fa
into
google:master
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations
LogDestination::DeleteLogDestinationsdeletessinks_but does not set the global toNULL.Further calls to
LogDestination::AddLogSinkwill incorrectly use the stalesinks_pointer and potentially crash (https://github.com/google/glog/blob/master/src/logging.cc#L621).This simple fix sets
sinks_toNULLafter thesinks_is deleted.