From 098177a48cae1bebfc90f88ed43d319444cab804 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucian=20Ro=C8=99u?= Date: Wed, 14 Jun 2023 19:41:42 +0300 Subject: [PATCH] blob/s3blob: fix the 'awssdk' argument examples --- blob/s3blob/example_test.go | 2 +- blob/s3blob/s3blob_test.go | 2 +- internal/website/data/examples.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blob/s3blob/example_test.go b/blob/s3blob/example_test.go index 77b798a626..87b97e3ec2 100644 --- a/blob/s3blob/example_test.go +++ b/blob/s3blob/example_test.go @@ -84,7 +84,7 @@ func Example_openBucketFromURL() { defer bucket.Close() // Forcing AWS SDK V2. - bucket, err = blob.OpenBucket(ctx, "s3://my-bucket?region=us-west-1&awssdk=2") + bucket, err = blob.OpenBucket(ctx, "s3://my-bucket?region=us-west-1&awssdk=v2") if err != nil { log.Fatal(err) } diff --git a/blob/s3blob/s3blob_test.go b/blob/s3blob/s3blob_test.go index 6e094ab595..865d920139 100644 --- a/blob/s3blob/s3blob_test.go +++ b/blob/s3blob/s3blob_test.go @@ -465,7 +465,7 @@ func TestOpenBucketFromURL(t *testing.T) { // OK, setting both profile and region. {"s3://mybucket?profile=main®ion=us-west-1", false}, // OK, use V2. - {"s3://mybucket?awssdk=2", false}, + {"s3://mybucket?awssdk=v2", false}, // Invalid parameter together with a valid one. {"s3://mybucket?profile=main¶m=value", true}, // Invalid parameter. diff --git a/internal/website/data/examples.json b/internal/website/data/examples.json index ffeb6bf779..4a0179ec35 100644 --- a/internal/website/data/examples.json +++ b/internal/website/data/examples.json @@ -69,7 +69,7 @@ }, "gocloud.dev/blob/s3blob.Example_openBucketFromURL": { "imports": "import (\n\t\"context\"\n\n\t\"gocloud.dev/blob\"\n\t_ \"gocloud.dev/blob/s3blob\"\n)", - "code": "// blob.OpenBucket creates a *blob.Bucket from a URL.\nbucket, err := blob.OpenBucket(ctx, \"s3://my-bucket?region=us-west-1\")\nif err != nil {\n\treturn err\n}\ndefer bucket.Close()\n\n// Forcing AWS SDK V2.\nbucket, err = blob.OpenBucket(ctx, \"s3://my-bucket?region=us-west-1\u0026awssdk=2\")\nif err != nil {\n\treturn err\n}\ndefer bucket.Close()" + "code": "// blob.OpenBucket creates a *blob.Bucket from a URL.\nbucket, err := blob.OpenBucket(ctx, \"s3://my-bucket?region=us-west-1\")\nif err != nil {\n\treturn err\n}\ndefer bucket.Close()\n\n// Forcing AWS SDK V2.\nbucket, err = blob.OpenBucket(ctx, \"s3://my-bucket?region=us-west-1\u0026awssdk=v2\")\nif err != nil {\n\treturn err\n}\ndefer bucket.Close()" }, "gocloud.dev/docstore.ExampleCollection_Actions_bulkWrite": { "imports": "import (\n\t\"context\"\n\n\t\"gocloud.dev/docstore\"\n)",