Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add support for Azure SQL providers #1305

Closed
vangent opened this issue Feb 12, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@vangent
Copy link
Contributor

commented Feb 12, 2019

Investigate what SQL options Azure supports (SQLServer? hosted MySQL? hosted Postgres?) and add support for them similar to what we have for AWS and GCP.

For SQL support, we basically just have helpers for opening the existing sql.DB type.

@vsaroopchand in case you're interested.
@zombiezen who has done most of the existing support.

@vangent

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Once this is fixed, we should also update the Azure part of the Guestbook sample to use a hosted SQL offering, and at that point we should also be able to run guestbook from an Azure VM (currently, it's running locally connecting to a local MySQL instance).

@vsaroopchand

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

Relational or Non-relational? The Azure Relational DB (AWS RDS equivalent) is Azure SQL which is a PaaS SQL service. The Non-relational service is CosmosDB which offers a MonboDb Driver Impl. along with a non-sql API. The CosmosDB sample is here; the Azure SQL sample is here. I can help with this as well.

@zombiezen

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

This is specifically referring to relational databases. Does Azure Relational DB only support MSSQL, or does it host MySQL/PostgreSQL as well?

@vsaroopchand

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

There are managed services for both PostgresSQL and MySQL. I am going to test the cloudpostgres package with an Azure PostgresSQL instance to see if that can be refactored to support Azure. There might be some differences in ports, etc. but should be possible unless you prefer a separate package for Azure PostgresSQL?

@zombiezen

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Thanks for the links. From quickly browsing the docs, it looks like Azure's offering is much closer to RDS than Cloud SQL in terms of code required: Azure serves using a CA not in the roots. The connection code (which should be in a separate package) should have a hook for the CA certificate fetching, and then open the connection with OpenCensus instrumentation.

@vangent vangent removed this from the Sprint 23 milestone Mar 1, 2019

@vsaroopchand

This comment has been minimized.

Copy link
Collaborator

commented Mar 5, 2019

I'll take this up now that Secrets is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.