Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: add ErrorAs #1197

Merged
merged 5 commits into from Jan 30, 2019

Conversation

@jba
Copy link
Contributor

jba commented Jan 26, 2019

  • Add an ErrorAs method to Topic and Subscription.
  • Add it to drivers as well.
  • Write test.

Fixes #957.

jba added 2 commits Jan 25, 2019
Fixes #957.
@jba jba requested review from ijt and vangent Jan 26, 2019
@googlebot googlebot added the cla: yes label Jan 26, 2019
pubsub/drivertest/drivertest.go Show resolved Hide resolved
pubsub/pubsub.go Show resolved Hide resolved
pubsub/rabbitpubsub/rabbit.go Outdated Show resolved Hide resolved
pubsub/gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
pubsub/rabbitpubsub/rabbit.go Outdated Show resolved Hide resolved
@jba

This comment has been minimized.

Copy link
Contributor Author

jba commented Jan 28, 2019

PTAL.

pubsub/rabbitpubsub/doc.go Outdated Show resolved Hide resolved
jba added 2 commits Jan 28, 2019
@jba

This comment has been minimized.

Copy link
Contributor Author

jba commented Jan 28, 2019

PTAL @ijt

@jba

This comment has been minimized.

Copy link
Contributor Author

jba commented Jan 30, 2019

@ijt ping

@ijt
ijt approved these changes Jan 30, 2019
@jba jba merged commit b4346d1 into google:master Jan 30, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
coverage/coveralls Coverage increased (+0.3%) to 80.914%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.