Add EquateErrors helper #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neild
approved these changes
Dec 16, 2019
cmp/cmpopts/equate.go
Outdated
| return !x.Add(a.margin).Before(y) | ||
| } | ||
|
|
||
| // AnyError is an error that matches all other non-nil errors. |
Collaborator
There was a problem hiding this comment.
AnyError matches itself as well, so perhaps "...that matches any non-nil error."?
cmp/cmpopts/equate.go
Outdated
| func (anyError) Is(err error) bool { return err != nil } | ||
|
|
||
| // EquateErrors returns a Comparer option that determines errors to be equal | ||
| // if errors.Is reports them to be equal. The AnyError error can be used to |
Collaborator
There was a problem hiding this comment.
"...if errors.Is reports them to match."
I've been trying (not always successfully) to use the verb "match" for the test performed by errors.Is.
The EquateErrors helper equates errors according to errors.Is. We also declare a sentinel AnyError value that matches any non-nil error value. This adds a dependency on golang.org/x/xerrors so that we can continue to suppport go1.8, which is our current minimally supported version of Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EquateErrors helper equates errors according to errors.Is.
We also declare a sentinel AnyError value that matches any
non-nil error value.
This adds a dependency on golang.org/x/xerrors so that we can
continue to suppport go1.8, which is our current minimally
supported version of Go.
Fixes #89