Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter should not leak implementation details #181

Open
dsnet opened this issue Jan 3, 2020 · 0 comments
Open

Exporter should not leak implementation details #181

dsnet opened this issue Jan 3, 2020 · 0 comments

Comments

@dsnet
Copy link
Member

@dsnet dsnet commented Jan 3, 2020

The exporter currently shallow copies a value if it is not addressable since the current implementation relies on addressability to forcibly export fields.

With the added PathStep.Values API, the user can now get access to the underlying reflect.Value. The CanAddr method leaks information about the underlying implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.