Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce minimum length for specialized string diffing #275

Merged
merged 3 commits into from Oct 12, 2021
Merged

Reduce minimum length for specialized string diffing #275

merged 3 commits into from Oct 12, 2021

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Sep 16, 2021

The original threshold of 64 was chosen without much thought.
Lower it to 32 now that we have some concrete examples
that it is aesthetically better.

Fixes #274

@dsnet
Copy link
Collaborator Author

dsnet commented Sep 16, 2021

\cc @neild

@dsnet dsnet changed the title Reduce minimum length for specialize string diffing Reduce minimum length for specialized string diffing Sep 16, 2021
The original threshold of 64 was chosen without much thought.
Lower it to 32 now that we have some concrete examples
that it is aesthetically better.
@neild neild self-requested a review September 17, 2021 00:57
neild
neild approved these changes Sep 17, 2021
@dsnet
Copy link
Collaborator Author

dsnet commented Oct 12, 2021

@neild. Merge please! :)

@neild neild merged commit 6faefd0 into google:master Oct 12, 2021
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff output is sometimes confusing and/or hard to read
2 participants