Permalink
Commits on Jan 16, 2018
  1. tests: make use of testMethod consistent (#832)

    sahildua2305 authored and gmlewis committed Jan 16, 2018
    Use testMethod to test the request method instead of manually comparing
    it and testing. This change is to make things consistent through out the
    code base.
    
    Fixes #829.
Commits on Dec 21, 2017
  1. Avoid modifying original request in RoundTrip. (#805)

    sahildua2305 authored and dmitshur committed Dec 21, 2017
    Avoid modifying the original request as per http.RoundTripper contract.
    In UnauthenticatedRateLimitedTransport.RoundTrip, we need to modify the
    URL of the request only, while in BasicAuthTransport.RoundTrip, we need
    to modify only the headers.
    
    We get rid of cloneRequest helper, which wasn't working well for the needs
    of UnauthenticatedRateLimitedTransport.RoundTrip. Instead, now we have
    the implementation of cloneRequest inlined in both RoundTrip methods.
    
    We decided to make the cloneRequest implementation inlined because its used
    at only these two places, and we think we won't gain much by making a
    generic implementation of cloneRequest as a function. For more information,
    see issue #556.
    
    Fixes #556.
Commits on Dec 2, 2017
  1. Remove generated accessors for Client struct and unexported fields. (#…

    sahildua2305 authored and dmitshur committed Dec 2, 2017
    …794)
    
    This change makes gen-accessors.go skip the following structs and fields
    from consideration when generating accessor methods:
    
    1.	Unexported structs and fields are skipped. They're unexported,
    	and shouldn't have accessors.
    2.	Client struct is explicitly blacklistd and skipped. It was not meant
    	to have accessors, and it doesn't need them.
    
    The generated accessors that are removed were added relatively recently,
    and it's not likely they were used since that time.
    
    Resolves #778.
Commits on Nov 22, 2017
  1. Add missing ",omitempty" option for pointer struct fields. (#787)

    sahildua2305 authored and dmitshur committed Nov 22, 2017
    This change improves consistency by adding missing ",omitempty"
    option where they belong. This makes it so that `nil` values get
    omitted when/if marshaled to JSON. Non-nil values are always
    included.
Commits on Nov 16, 2017
  1. repos: add archived boolean field to Repository struct (#782)

    sahildua2305 authored and gmlewis committed Nov 16, 2017
    Add Archived flag to Repository struct as per changes announced by GitHub
    - https://developer.github.com/changes/2017-11-08-archiving-repositories/
Commits on Nov 8, 2017
Commits on May 15, 2017
  1. Add Community Health metrics preview API. (#628)

    sahildua2305 authored and dmitshur committed May 15, 2017
    This is a new preview API to retrieve community health metrics for any
    public repository.
    
    Announcement: https://developer.github.com/changes/2017-02-09-community-health/
    GitHub API Docs: https://developer.github.com/v3/repos/community/
    
    Resolves #553.
Commits on May 7, 2017
Commits on Feb 3, 2017
  1. Add support for new pull request review API

    sahildua2305 authored and gmlewis committed Dec 16, 2016
    Fixes #495.
    Closes #497.
    
    Change-Id: If266972e7a20f83afaa842d54c22846bbb435328
Commits on Jan 31, 2017
  1. Add support for Commit Search endpoint

    sahildua2305 authored and gmlewis committed Jan 17, 2017
    Added support for this new preview endpoint which lets users
    search for commits based on various conditions.
    
    GitHub announcement -
    https://developer.github.com/changes/2017-01-05-commit-search-api/
    Docs - https://developer.github.com/v3/search/#search-commits
    
    Fixes #508.
    Closes #520.
    
    Change-Id: I2210fafe3da530716075f9113851e09e3bc671f8