-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add CancelInvite method to cancel an org invitation by ID #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3263 +/- ##
==========================================
- Coverage 97.72% 92.97% -4.75%
==========================================
Files 153 171 +18
Lines 13390 11721 -1669
==========================================
- Hits 13085 10898 -2187
- Misses 215 729 +514
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown !
One minor tweak to address, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo (plus the signed CLA) before merging.
8bbf034 to
60063be
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the errors locally by reading step 4 in CONTRIBUTING.md
and sign the CLA, then we can move forward with this PR.
60063be to
033442e
Compare
I ran the scripts, and everything should be OK now. |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown !
LGTM.
Awaiting signed CLA, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
|
@gmlewis : CCLA has finally been signed for the whole |
2233f7b to
8bad333
Compare
It looks like 3 emails were found for this PR. You need to make sure that only the email that is part of the signed CLA is on this PR. If you click on the "Details" link, it says this:
So you can either fix all the commits and force-push to this PR, |
8bad333 to
2c4880f
Compare
|
After a lot of internal shenanigans, it looks like the CLA approval is now being properly reported 🥳 |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
andygrunwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. Thanks @DocEmmetBrown.
@gmlewis I hope this review helps you with this PR.
|
Thank you, @andygrunwald ! |
The https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#cancel-an-organization-invitation endpoint was not available, and I needed it for some tooling.
I tried my best to stick to the standards, and added a quick test.
Happy to update / change anything if required.