-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor!: Replace Edit with Update in permissions method names
#3731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Edit with Update in permissions method names
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3731 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 187 187
Lines 16686 16686
=======================================
Hits 15204 15204
Misses 1295 1295
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @zyfy29!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear
|
@gmlewis Thanks, it's nice to see you back! |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @stevehipwell! |
BREAKING CHANGE: Permissions-related methods are renamed from
Edit*toUpdate*.Rename the methods
EditXXXtoUpdateXXXfor the permissions related apisaccomplish #3679 (comment)