New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support preview Organizations Membership API and new filter #524

Closed
gmlewis opened this Issue Jan 19, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@glapul

This comment has been minimized.

Show comment
Hide comment
@glapul

glapul Jan 25, 2017

Contributor

Hi, I'd like to work on it.

The issue sounds like there already is some code that lists organization's outside collaborator, and only the support for the new filter is to be added, but I couldn't find any. Am I missing something, or should I also write the code for that?

Contributor

glapul commented Jan 25, 2017

Hi, I'd like to work on it.

The issue sounds like there already is some code that lists organization's outside collaborator, and only the support for the new filter is to be added, but I couldn't find any. Am I missing something, or should I also write the code for that?

@gmlewis

This comment has been minimized.

Show comment
Hide comment
@gmlewis

gmlewis Jan 25, 2017

Collaborator

Thank you, @glapul - I'll send you an invite so that I can assign it to you.

Collaborator

gmlewis commented Jan 25, 2017

Thank you, @glapul - I'll send you an invite so that I can assign it to you.

@gmlewis

This comment has been minimized.

Show comment
Hide comment
@gmlewis

gmlewis Jan 25, 2017

Collaborator

You are correct. The new Organizations Membership API needs to be supported too.

Announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/
I'll change the label for this issue, and it can address both.

Collaborator

gmlewis commented Jan 25, 2017

You are correct. The new Organizations Membership API needs to be supported too.

Announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/
I'll change the label for this issue, and it can address both.

@gmlewis gmlewis changed the title from Support new filter for listing outside collaborators without two-factor authentication enabled to Support preview Organizations Membership API and new filter Jan 25, 2017

@glapul

This comment has been minimized.

Show comment
Hide comment
@glapul

glapul Feb 1, 2017

Contributor

#538 I've implemented the support for listing outside collaborators. Feedback?

Contributor

glapul commented Feb 1, 2017

#538 I've implemented the support for listing outside collaborators. Feedback?

@elliott-beach

This comment has been minimized.

Show comment
Hide comment
@elliott-beach

elliott-beach Aug 20, 2017

Contributor

Should this be closed, as #538 was closed and merged?

Contributor

elliott-beach commented Aug 20, 2017

Should this be closed, as #538 was closed and merged?

@gmlewis

This comment has been minimized.

Show comment
Hide comment
@gmlewis

gmlewis Aug 21, 2017

Collaborator

From a quick glance at this announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/ it appears that #538 did not fully support all the new API endpoints. For example, I don't think Remove an outside collaborator was addressed. There may be more, and part of the ownership of an issue (in my opinion) is to investigate what all is needed to completely resolve the issue.

If @glapul would like to complete this issue, then @glapul is welcome to... otherwise if someone else would like to read the announcements and add the missing endpoints, that is fine with me too.

Collaborator

gmlewis commented Aug 21, 2017

From a quick glance at this announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/ it appears that #538 did not fully support all the new API endpoints. For example, I don't think Remove an outside collaborator was addressed. There may be more, and part of the ownership of an issue (in my opinion) is to investigate what all is needed to completely resolve the issue.

If @glapul would like to complete this issue, then @glapul is welcome to... otherwise if someone else would like to read the announcements and add the missing endpoints, that is fine with me too.

@kshitij10496

This comment has been minimized.

Show comment
Hide comment
@kshitij10496

kshitij10496 Dec 16, 2017

Collaborator

Hey @gmlewis

I would like to share my research on the implementation of the new endpoints mentioned in the announcement:

Endpoint Implemented File:Method
Review a user's permission level Yes repos_collaborators.go:GetPermissionLevel
List outside collaborators Yes orgs_outside_collaborators.go:ListOutsideCollaborators
Remove an outside collaborator No -
Convert a member to an outside collaborator No -
List pending organization invitations Yes orgs_members.go:ListPendingOrgInvitations
List pending team invitations Yes orgs_teams.go:ListPendingTeamInvitations

If no one else is working on this, I would be more than happy to implement the missing endpoints.

Collaborator

kshitij10496 commented Dec 16, 2017

Hey @gmlewis

I would like to share my research on the implementation of the new endpoints mentioned in the announcement:

Endpoint Implemented File:Method
Review a user's permission level Yes repos_collaborators.go:GetPermissionLevel
List outside collaborators Yes orgs_outside_collaborators.go:ListOutsideCollaborators
Remove an outside collaborator No -
Convert a member to an outside collaborator No -
List pending organization invitations Yes orgs_members.go:ListPendingOrgInvitations
List pending team invitations Yes orgs_teams.go:ListPendingTeamInvitations

If no one else is working on this, I would be more than happy to implement the missing endpoints.

@dmitshur dmitshur closed this in 218ecc2 Jan 6, 2018

nbareil pushed a commit to nbareil/go-github that referenced this issue May 1, 2018

Add Outside Collaborators API to OrganizationsService. (google#812)
This change implements two methods on OrganizationsService
corresponding to endpoints of the Outside Collaborators API:

-	RemoveOutsideCollaborator
-	ConvertMemberToOutsideCollaborator

(ListOutsideCollaborators was already implemented.)

GitHub API docs: https://developer.github.com/v3/orgs/outside_collaborators.

Resolves google#524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment