Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support delete files for CreateTree #1310

Open
wants to merge 3 commits into
base: master
from

Conversation

@helmus
Copy link

helmus commented Oct 14, 2019

Improved version of #1307
Solves #1268
I think it actually is this simple @gmlewis 馃槄

@googlebot googlebot added the cla: yes label Oct 14, 2019
@helmus helmus changed the title support delete Support delete files for CreateTree Oct 14, 2019
helmus added 2 commits Oct 14, 2019
fmt
fmt
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1310 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   73.42%   73.55%   +0.13%     
==========================================
  Files          86       86              
  Lines        6047     6077      +30     
==========================================
+ Hits         4440     4470      +30     
  Misses        837      837              
  Partials      770      770
Impacted Files Coverage 螖
github/git_trees.go 93.22% <100%> (+7.01%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a291ecb...73ec82b. Read the comment docs.

Copy link
Collaborator

gmlewis left a comment

GENIUS!!!

Now that's what I'm talking about, @helmus!!!

I love it! Looks Great To Me!!!

If @gauntface is OK with this, we are good to merge.

I sincerely thank you, @helmus for being patient with me in the other PR and for coming across this elegant solution. It's times like this that makes this volunteer work fun and interesting!

@helmus

This comment has been minimized.

Copy link
Author

helmus commented Oct 24, 2019

@gauntface anything else you think is missing in this pr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.