Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump major version to v29" #1366

Merged
merged 1 commit into from Jan 8, 2020
Merged

Revert "Bump major version to v29" #1366

merged 1 commit into from Jan 8, 2020

Conversation

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 8, 2020

Reverts #1344 due to breaking the build.

This reverts commit cfb91a4.
@googlebot googlebot added the cla: yes label Jan 8, 2020
@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

gmlewis commented Jan 8, 2020

Merging to fix build. I'll address v29 later tonight. Sorry for all the noise. :-(

@gmlewis gmlewis merged commit 26c91e4 into master Jan 8, 2020
9 checks passed
9 checks passed
linux (1.x)
Details
linux (1.x)
Details
linux (1.12.x)
Details
linux (1.12.x)
Details
windows (1.x)
Details
windows (1.x)
Details
windows (1.12.x)
Details
windows (1.12.x)
Details
cla/google All necessary CLAs are signed
@gmlewis gmlewis deleted the revert-1344-v29 branch Jan 8, 2020
@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 8, 2020

No problem @gmlewis, thank you for taking care of this.

I believe the issue in PR #1344 was that it did not update the recently added example/topics/main.go file, it still imports "github.com/google/go-github/v28/github" instead of "github.com/google/go-github/v29/github": https://github.com/google/go-github/blob/v29.0.0/example/topics/main.go#L15.

After we fix this, we'll need to pick a new version number, because v29.0.0 has already been published. Perhaps v29.0.1, since this will be fixing up a minor problem.

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

gmlewis commented Jan 8, 2020

Ah, thank you for the analysis, @dmitshur !
I'm going to try and remedy it now.
(I deleted the v29.0.0 if that makes any difference.)

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 9, 2020

(I deleted the v29.0.0 if that makes any difference.)

That version has already been indexed and added to the Go checksum database, so we still won't be able to publish the same module version with different content without it causing a mismatch in the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.