Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump major version to v29 (take 2) #1367

Merged
merged 7 commits into from Jan 9, 2020
Merged

Bump major version to v29 (take 2) #1367

merged 7 commits into from Jan 9, 2020

Conversation

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 9, 2020

This is the second attempt to bump the major version to v29 after #1344 failed.
Release v29.0.0 was broken so this will be released as v29.0.1.

gmlewis added 7 commits Dec 4, 2019
@gmlewis gmlewis requested a review from dmitshur Jan 9, 2020
@googlebot googlebot added the cla: yes label Jan 9, 2020
@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

@dmitshur - if you could please check this when you get a chance, I would greatly appreciate it!
I will release this as v29.0.1 if there are no objections.

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

Fixes #1365.

Copy link
Member

dmitshur left a comment

LGTM. I tested this change and don't see any issues.

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

Thank you, @dmitshur!
Merging.

@gmlewis gmlewis merged commit a3f3689 into google:master Jan 9, 2020
5 checks passed
5 checks passed
linux (1.x)
Details
linux (1.12.x)
Details
windows (1.x)
Details
windows (1.12.x)
Details
cla/google All necessary CLAs are signed
@gmlewis gmlewis deleted the gmlewis:v29 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.