Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListPullsForCommit #1872

Closed
wants to merge 1 commit into from
Closed

Conversation

emmjohnson
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented May 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1872 (e7a9369) into master (77a5f59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1872   +/-   ##
=======================================
  Coverage   97.65%   97.66%           
=======================================
  Files         105      105           
  Lines        6783     6796   +13     
=======================================
+ Hits         6624     6637   +13     
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/repos_commits.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a5f59...e7a9369. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emmjohnson , but I believe this endpoint is already implemented here:
https://github.com/google/go-github/blob/master/github/pulls.go#L159-L185

@gmlewis gmlewis added the DO NOT MERGE Do not merge this PR. label Jul 13, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 16, 2021

Closing as already implemented.

@gmlewis gmlewis closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no DO NOT MERGE Do not merge this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants