Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional PagesUpdate parameters #2266



Copy link

@quinqu quinqu commented Jan 22, 2022

Closes #2261

This change introduces 2 additional parameters provided by the GitHub API to the PagesUpdate type, Public and HTTPSEnforced.

Note: I had to open a new PR because the author email for one of the commits in the first PR did not match the email associated with my CLA.

Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #2266 (735ed9f) into master (d4c1caf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2266   +/-   ##
  Coverage   97.81%   97.81%           
  Files         114      114           
  Lines       10266    10266           
  Hits        10042    10042           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/repos_pages.go 97.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c1caf...735ed9f. Read the comment docs.

Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @quinqu !

@gmlewis gmlewis merged commit 975d1d0 into google:master Jan 22, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Support additional GitHub pages update parameters
2 participants