Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting actions permissions on a repository #2315

Merged
merged 10 commits into from Mar 25, 2022

Conversation

h2floh
Copy link
Contributor

@h2floh h2floh commented Mar 16, 2022

馃憢 Hello there!

Couldn't find a PR for it yet so added functionality requested in #2297
Sorry if I pushed myself before @cfarrend in doing it but I will need the changes.

Went through the contributing guide and also added an example to test the change end2end.

Thanks everyone!

Fixes: #2297.

Signed-off-by: GitHub <noreply@github.com>
@google-cla
Copy link

google-cla bot commented Mar 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2315 (ddff22b) into master (f859098) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
+ Coverage   97.84%   97.85%   +0.01%     
==========================================
  Files         115      117       +2     
  Lines       10416    10466      +50     
==========================================
+ Hits        10192    10242      +50     
  Misses        156      156              
  Partials       68       68              
Impacted Files Coverage 螖
github/orgs_actions_allowed.go 100.00% <酶> (酶)
github/repos_actions_allowed.go 100.00% <100.00%> (酶)
github/repos_actions_permissions.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f859098...ddff22b. Read the comment docs.

@h2floh
Copy link
Contributor Author

h2floh commented Mar 23, 2022

Hey @gmlewis , I signed the ICLA after my company asked me to do that. Can you please rerun the cla check. Thanks!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @h2floh !
Just a few tweaks, please, then we should be ready for a second review before merging.

example/actionpermissions/main.go Outdated Show resolved Hide resolved
example/actionpermissions/main.go Outdated Show resolved Hide resolved
github/repos_actions_allowed.go Outdated Show resolved Hide resolved
github/repos_actions_allowed.go Outdated Show resolved Hide resolved
github/repos_actions_allowed.go Show resolved Hide resolved
github/repos_actions_permissions.go Outdated Show resolved Hide resolved
github/repos_actions_permissions.go Show resolved Hide resolved
github/repos_actions_permissions.go Outdated Show resolved Hide resolved
github/repos_actions_permissions.go Outdated Show resolved Hide resolved
github/repos_actions_permissions.go Outdated Show resolved Hide resolved
h2floh and others added 8 commits March 24, 2022 12:26
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@gmlewis gmlewis changed the title Support for setting actions permissions for a repository Add support for setting actions permissions on a repository Mar 24, 2022
github/repos_actions_allowed_test.go Show resolved Hide resolved
github/repos_actions_permissions_test.go Show resolved Hide resolved
Signed-off-by: GitHub <noreply@github.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 25, 2022

@Parker77 - do you have time for a code review?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @h2floh !
LGTM.

Awaiting second LGTM before merging.

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 25, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 6d5a72e into google:master Mar 25, 2022
7 checks passed
@h2floh h2floh deleted the h2floh/2297 branch March 25, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting actions permissions for a repository
3 participants