Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up method return consistency #2318

merged 11 commits into from Mar 25, 2022


Copy link

@gmlewis gmlewis commented Mar 24, 2022

@h2floh pointed out in #2315 that our method returns are inconsistent.
This PR addresses this inconsistency.

@h2floh - please review and LGTM+Approve this PR if you agree to the changes.

Copy link
Collaborator Author

gmlewis commented Mar 24, 2022

According to , actions are currently experiencing degraded performance, which is why no tests have run as of yet.

Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #2318 (977aa72) into master (1694b79) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2318      +/-   ##
+ Coverage   97.95%   98.04%   +0.09%     
  Files         117      117              
  Lines       10402    10460      +58     
+ Hits        10189    10256      +67     
+ Misses        146      140       -6     
+ Partials       67       64       -3     
Impacted Files Coverage Δ
github/activity_star.go 100.00% <ø> (ø)
github/gists.go 96.68% <ø> (ø)
github/github.go 97.73% <ø> (ø)
github/orgs_members.go 98.35% <ø> (ø)
github/repos_collaborators.go 100.00% <ø> (ø)
github/repos_contents.go 89.33% <ø> (ø)
github/billing.go 100.00% <100.00%> (ø)
github/git_blobs.go 100.00% <100.00%> (ø)
github/git_tags.go 100.00% <100.00%> (ø)
github/issues_assignees.go 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694b79...977aa72. Read the comment docs.

Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

@Parker77 - do you have time for a code review?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

Thank you, @Parker77 !

@gmlewis gmlewis merged commit 3e8a7f0 into google:master Mar 25, 2022
7 checks passed
@gmlewis gmlewis deleted the fix-method-return-inconsistency branch March 25, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants