Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rolename field to user struct #2386

merged 1 commit into from Jun 16, 2022

add rolename field to user struct #2386

merged 1 commit into from Jun 16, 2022


Copy link

@joshua-hancox joshua-hancox commented Jun 16, 2022

As a follow on from this PR - I also need to be able to access the role_name returned from the Repositories.ListCollaborators endpoint, and therefore have raised this PR to include the field in the user struct.

Copy link

google-cla bot commented Jun 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #2386 (7d99f0c) into master (74c4599) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2386   +/-   ##
  Coverage   98.06%   98.06%           
  Files         119      119           
  Lines       10545    10545           
  Hits        10341    10341           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/users.go 94.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c4599...7d99f0c. Read the comment docs.

Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshua-hancox !

@gmlewis gmlewis merged commit 697804f into google:master Jun 16, 2022
10 checks passed
@joshua-hancox joshua-hancox deleted the role-name-user-struct branch June 21, 2022 06:55
Copy link
Contributor Author

Hey @gmlewis - any chance we could get a release with this functionality?

Copy link

gmlewis commented Jun 21, 2022

Hey @gmlewis - any chance we could get a release with this functionality?

Hi @joshua-hancox - yes, this is now included in v45.2.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants