Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state_reason to IssuesService.Edit #2395

merged 1 commit into from Jun 24, 2022


Copy link

@parkr parkr commented Jun 23, 2022

state_reason can be 'completed' or 'not_planned'.

I believe we let GitHub document these values, but let me know if you need me to modify this change. Thank you!

Fixes #2393.

/cc @gmlewis

@parkr parkr force-pushed the issues-closed-reason branch 2 times, most recently from c7561ea to 016c951 Compare June 23, 2022 05:53
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2395 (879d435) into master (8309da1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2395   +/-   ##
  Coverage   98.06%   98.06%           
  Files         119      119           
  Lines       10546    10546           
  Hits        10342    10342           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/issues.go 97.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8309da1...879d435. Read the comment docs.

state_reason can be 'completed' or 'not_planned'.
Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @parkr !

github/issues.go Show resolved Hide resolved
@gmlewis gmlewis changed the title IssuesService.Edit: add state_reason Add state_reason to IssuesService.Edit Jun 24, 2022
@gmlewis gmlewis merged commit 404bf94 into google:master Jun 24, 2022
10 checks passed
@parkr parkr deleted the issues-closed-reason branch June 24, 2022 03:45
Copy link
Contributor Author

parkr commented Jun 24, 2022

Thank you so much, @gmlewis!

orestisfl added a commit to orestisfl/i3-github-bot that referenced this pull request Sep 3, 2022
stapelberg pushed a commit to i3/i3-github-bot that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Support state_reason in IssuesService.Edit
2 participants