Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cursor pagination in AlertListOptions #2512

merged 2 commits into from Nov 4, 2022


Copy link

Fixes #2511

Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2512 (2e1dbea) into master (fce4030) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2512   +/-   ##
  Coverage   97.97%   97.97%           
  Files         123      123           
  Lines       10813    10813           
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

gmlewis commented Oct 28, 2022

Waiting for reply: #2511 (comment)

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. and removed waiting for reply labels Nov 3, 2022
gmlewis approved these changes Nov 3, 2022
Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !

Awaiting LGTM+Approval from any other contributor to this repo before merging.

valbeat approved these changes Nov 4, 2022
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 4, 2022
Copy link

gmlewis commented Nov 4, 2022

Thank you, @valbeat !

@gmlewis gmlewis merged commit 020d9ae into google:master Nov 4, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

ListAlertsForOrg options should support cursor pagination
3 participants