Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for JSON resource marshaling #2517

merged 1 commit into from Oct 25, 2022


Copy link

@akshaypatil3096 akshaypatil3096 commented Oct 25, 2022

Hi creators,
I have added test case for :
IDPGroupList struct
under Helps: #55 issue

I have followed all the guidelines to contribute in this repository.
Please revert in case of any changes needed.
I am first time contributor of Hackoctober , It will be great if you review & accept my contribution.

Copy link
Contributor Author

Hi @gmlewis pls accept my PR for Hackoctober fest contribution.

@akshaypatil3096 akshaypatil3096 changed the title added test case for IDPGroupList struct marshaling Add test cases for JSON resource marshaling Oct 25, 2022
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2517 (f97c9aa) into master (672fd67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2517   +/-   ##
  Coverage   97.97%   97.97%           
  Files         123      123           
  Lines       10813    10813           
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @akshaypatil3096 !

@gmlewis gmlewis changed the title Add test cases for JSON resource marshaling Add test case for JSON resource marshaling Oct 25, 2022
@gmlewis gmlewis merged commit 914d25e into google:master Oct 25, 2022
10 checks passed
Harikesh00 pushed a commit to Harikesh00/go-github that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants