Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for JSON resource marshaling #2526

merged 1 commit into from Oct 25, 2022


Copy link

Hi creators,
I have added test cases for :
SCIMUserName struct
under Helps: #55 issue

I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be great if you review & accept my contribution.

@gmlewis gmlewis changed the title Add test cases for JSON resource marshaling Add test case for JSON resource marshaling Oct 25, 2022
Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vaibhavgholap23 !

Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2526 (fa7dd54) into master (330d92d) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2526      +/-   ##
- Coverage   98.03%   97.97%   -0.07%     
  Files         122      123       +1     
  Lines       10705    10813     +108     
+ Hits        10495    10594      +99     
- Misses        144      150       +6     
- Partials       66       69       +3     
Impacted Files Coverage Δ
github/orgs_custom_roles.go 94.23% <0.00%> (-5.77%) ⬇️
github/repos.go 98.67% <0.00%> (ø)
github/enterprise_actions_runners.go 100.00% <0.00%> (ø)
github/users_ssh_signing_keys.go 89.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

gmlewis commented Oct 25, 2022

Please ignore the above Codecov Report, as it is clearly wrong.

@gmlewis gmlewis merged commit d17bf21 into google:master Oct 25, 2022
9 of 10 checks passed
Harikesh00 pushed a commit to Harikesh00/go-github that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants