Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for resource JSON marshaling #2538


Copy link

@tsbkw tsbkw commented Oct 28, 2022

Added test for TrafficBreakdownOptions

Helps: #55

Copy link

google-cla bot commented Oct 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tsbkw tsbkw marked this pull request as ready for review October 28, 2022 03:36
@gmlewis gmlewis changed the title test: Add tests for resource JSON marshalling - TrafficBreakdownOptions Add test for resource JSON marshaling Oct 28, 2022
Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tsbkw !

Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2538 (9c983a8) into master (f550bc8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2538   +/-   ##
  Coverage   97.97%   97.97%           
  Files         123      123           
  Lines       10813    10813           
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis merged commit fd784db into google:master Oct 28, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants