Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for JSON resource marshaling #2541

merged 3 commits into from Oct 28, 2022


Copy link

Hi creator,
Added test cases for JSON Resources :
Helps: #55

I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be a great help if u can encourage me & accept my contribution.

@gmlewis gmlewis changed the title Team test external group member Add test case for JSON resource marshaling Oct 28, 2022
Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rahulkarmore !

Waiting for GitHub Actions to perform all checks before merging.

Copy link

gmlewis commented Oct 28, 2022

@rahulkarmore - if GitHub Actions doesn't kick in within an hour or so, please feel free to tweak one of your constants in your PR and push the change to this PR... hopefully that will kick GHA into gear... it looks like it is currently either having issues or is just sleeping. 😁

Copy link

gmlewis commented Oct 28, 2022

Thank you, @rahulkarmore ! Do you want to resolve the conflicts by merging in the master branch (again), or would you like me to do that?

Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2541 (92a2236) into master (cb9253a) will not change coverage.
The diff coverage is n/a.

Current head 92a2236 differs from pull request most recent head f05ba3d. Consider uploading reports for the commit f05ba3d to get more accurate results

@@           Coverage Diff           @@
##           master    #2541   +/-   ##
  Coverage   97.97%   97.97%           
  Files         123      123           
  Lines       10813    10813           
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor Author

resolved conflict

@rahulkarmore rahulkarmore reopened this Oct 28, 2022
@gmlewis gmlewis merged commit 81b88b0 into google:master Oct 28, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants