Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunAttempt field for WorkflowJob #2562

Merged
merged 7 commits into from Nov 25, 2022

Conversation

paveldvoinos
Copy link
Contributor

@paveldvoinos paveldvoinos commented Nov 9, 2022

Add RunAttempt field for WorkflowJob

@google-cla
Copy link

google-cla bot commented Nov 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title added RunAttempt field for WorkflowJob Add RunAttempt field for WorkflowJob Nov 9, 2022
@paveldvoinos
Copy link
Contributor Author

@gmlewis Can you pls check if this can go live?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @paveldvoinos , and I apologize for letting this one slip through the cracks.
Thanks also for the reminder, I appreciate it.

LGTM.
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 22, 2022

Whups, it looks like the modified files need gofmt and/or you need to run go generate ./... in the top of the repo... both described in more detail in CONTRIBUTING.md. I'll wait until you do that and push the results. Thanks.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #2562 (82de3d5) into master (593e21e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2562   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         125      125           
  Lines       10875    10875           
=======================================
  Hits        10656    10656           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/actions_workflow_jobs.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paveldvoinos
Copy link
Contributor Author

@gmlewis I tried and fmt does no difference.

Also ,I have concerns that the linting check itself is broken: this is the error the step fails with:

Running [/home/runner/golangci-lint-1.44.0-linux-amd64/golangci-lint run --out-format=github-actions --verbose] in [] ...
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 24, 2022

@gmlewis I tried and fmt does no difference.

Also ,I have concerns that the linting check itself is broken: this is the error the step fails with:

Running [/home/runner/golangci-lint-1.44.0-linux-amd64/golangci-lint run --out-format=github-actions --verbose] in [] ...
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

Yes, it looks like we need to use v3 a newer version here: https://stackoverflow.com/questions/71758856/github-action-for-golangci-lint-fails-with-cant-load-fmt

It looks like v1.50.1 is what we need to use:
golangci/golangci-lint#3107

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 24, 2022

Hmmm... we are already using the latest version: https://github.com/golangci/golangci-lint-action/releases/tag/v3.3.1

You ran go generate ./... correct, @paveldvoinos ?

@paveldvoinos
Copy link
Contributor Author

yes, generated files included

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 24, 2022

@paveldvoinos - could you please git pull on the master branch and then merge it into this branch and push again to this PR?
Let's see if bumping the version of golangci-lint fixes the problem.
Thank you, and I apologize for the hassle.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 25, 2022

That worked! Merging. Thank you for your patience, @paveldvoinos !

@gmlewis gmlewis merged commit 621c4ba into google:master Nov 25, 2022
10 checks passed
@paveldvoinos paveldvoinos deleted the add-workflow-job-run-attempt branch November 25, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants