/ go-github Public
Support new GitHub v3 API calendar-based versioning #2581
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
@willnorris - please see if you agree with this approach for supporting the new GitHub v3 API versioning mechanism.
My thought is that when they add breaking API changes, that we will continue to support them, but will now add the
WithVersionoption to each request that needs it.