support 'since' pagination #278
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing 'since' from Link header, which enables us to actually paginate through listing Users. This is especially helpful when working with Github Enterprise.
https://developer.github.com/v3/users/#get-all-users
Also, this is kind of a hack since we're overloading the idea of a 'Page' but it does work well with code like this:
Also I did not add tests - if we want tests, and we want this code, I can write tests.