From bf8dda0ec94e498e9510c7f740f514ed0c30e8c9 Mon Sep 17 00:00:00 2001 From: Matt Mencel Date: Wed, 21 Aug 2024 22:27:12 -0500 Subject: [PATCH 1/2] feat: add do_not_enforce_on_create to required status checks rule params --- github/repos_rules.go | 1 + github/repos_rules_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/github/repos_rules.go b/github/repos_rules.go index 17fa170cf99..6d394164ced 100644 --- a/github/repos_rules.go +++ b/github/repos_rules.go @@ -111,6 +111,7 @@ type RuleRequiredStatusChecks struct { // RequiredStatusChecksRuleParameters represents the required_status_checks rule parameters. type RequiredStatusChecksRuleParameters struct { + DoNotEnforceOnCreate bool `json:"do_not_enforce_on_create"` RequiredStatusChecks []RuleRequiredStatusChecks `json:"required_status_checks"` StrictRequiredStatusChecksPolicy bool `json:"strict_required_status_checks_policy"` } diff --git a/github/repos_rules_test.go b/github/repos_rules_test.go index c338e37e335..b79af5cc280 100644 --- a/github/repos_rules_test.go +++ b/github/repos_rules_test.go @@ -226,6 +226,7 @@ func TestRepositoryRule_UnmarshalJSON(t *testing.T) { "Valid required_status_checks params": { data: `{"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test","integration_id":1}],"strict_required_status_checks_policy":true}}`, want: NewRequiredStatusChecksRule(&RequiredStatusChecksRuleParameters{ + DoNotEnforceOnCreate: true, RequiredStatusChecks: []RuleRequiredStatusChecks{ { Context: "test", From 5c88e6f2934ea05510f6765f92abd45d4e418580 Mon Sep 17 00:00:00 2001 From: Matt Mencel Date: Thu, 22 Aug 2024 07:45:39 -0500 Subject: [PATCH 2/2] chore: fix test --- github/repos_rules_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repos_rules_test.go b/github/repos_rules_test.go index b79af5cc280..92f7259d0c8 100644 --- a/github/repos_rules_test.go +++ b/github/repos_rules_test.go @@ -224,7 +224,7 @@ func TestRepositoryRule_UnmarshalJSON(t *testing.T) { wantErr: true, }, "Valid required_status_checks params": { - data: `{"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test","integration_id":1}],"strict_required_status_checks_policy":true}}`, + data: `{"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test","integration_id":1}],"strict_required_status_checks_policy":true,"do_not_enforce_on_create":true}}`, want: NewRequiredStatusChecksRule(&RequiredStatusChecksRuleParameters{ DoNotEnforceOnCreate: true, RequiredStatusChecks: []RuleRequiredStatusChecks{