New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the GitHub Authorizations API per issue #119 #325

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@neilotoole
Contributor

neilotoole commented Apr 3, 2016

Implement the GitHub Authorizations API. See issue #119.

  • Unit and integration tests are provided.
  • Integration tests require that certain environment variables are specified, see the updated tests/README.md
  • For example usage, see the integration tests in tests/integration/authorizations_test.go
  • Edited top-level README.md to provide a link to the tests/README.md and removed content that was duplicated in the top-level file.
Implements the GitHub Authorizations API per issue #119
- Unit and integration tests are included.
- See the tests/README.md for integration test instructions.
- See the integration test for example usage.
@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Apr 5, 2016

Member

So this largely duplicates the work in #241 that I just hadn't gotten around to merging in yet. You do have a lot of additional niceties here like the integration tests, so I'll see about applying that and some other things on top of #241 once I get it merged.

Member

willnorris commented Apr 5, 2016

So this largely duplicates the work in #241 that I just hadn't gotten around to merging in yet. You do have a lot of additional niceties here like the integration tests, so I'll see about applying that and some other things on top of #241 once I get it merged.

@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Apr 5, 2016

Member

I'll be merging this in just a moment. I broke it into two commits, one that builds on top of #241 to include things like the Scope type and values, as well as some updates to the function docs that you had. Then the second commit has the integration tests. There were some small changes to that, mostly relating to variable naming. Thanks for contributing this!

Member

willnorris commented Apr 5, 2016

I'll be merging this in just a moment. I broke it into two commits, one that builds on top of #241 to include things like the Scope type and values, as well as some updates to the function docs that you had. Then the second commit has the integration tests. There were some small changes to that, mostly relating to variable naming. Thanks for contributing this!

@willnorris willnorris closed this in 5379d93 Apr 5, 2016

@neilotoole

This comment has been minimized.

Show comment
Hide comment
@neilotoole

neilotoole Apr 5, 2016

Contributor

Well dang @willnorris, remind me in future to check the other PRs! Glad to be of assistance.

Contributor

neilotoole commented Apr 5, 2016

Well dang @willnorris, remind me in future to check the other PRs! Glad to be of assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment