From 539d647e495a3307b99fb9ea12637ad10087599e Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Sat, 5 Oct 2024 10:22:25 +0300 Subject: [PATCH 1/2] chore: Remove deprecated build constraints --- github/gen-accessors.go | 1 - github/gen-stringify-test.go | 1 - github/with_appengine.go | 1 - github/without_appengine.go | 1 - test/integration/activity_test.go | 1 - test/integration/audit_log_test.go | 1 - test/integration/authorizations_test.go | 1 - test/integration/github_test.go | 1 - test/integration/issues_test.go | 1 - test/integration/misc_test.go | 1 - test/integration/pulls_test.go | 1 - test/integration/repos_test.go | 1 - test/integration/users_test.go | 1 - 13 files changed, 13 deletions(-) diff --git a/github/gen-accessors.go b/github/gen-accessors.go index 4bc22acdc15..0cc36b9bbe0 100644 --- a/github/gen-accessors.go +++ b/github/gen-accessors.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build ignore -// +build ignore // gen-accessors generates accessor methods for structs with pointer fields. // diff --git a/github/gen-stringify-test.go b/github/gen-stringify-test.go index 5a42082b93d..fcf648726b5 100644 --- a/github/gen-stringify-test.go +++ b/github/gen-stringify-test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build ignore -// +build ignore // gen-stringify-test generates test methods to test the String methods. // diff --git a/github/with_appengine.go b/github/with_appengine.go index 9053ce1059b..9bb95b8c89c 100644 --- a/github/with_appengine.go +++ b/github/with_appengine.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build appengine -// +build appengine // This file provides glue for making github work on App Engine. diff --git a/github/without_appengine.go b/github/without_appengine.go index 0024ae4157e..bfdb18ecbb2 100644 --- a/github/without_appengine.go +++ b/github/without_appengine.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build !appengine -// +build !appengine // This file provides glue for making github work without App Engine. diff --git a/test/integration/activity_test.go b/test/integration/activity_test.go index 32d499c8080..1f231eaf49e 100644 --- a/test/integration/activity_test.go +++ b/test/integration/activity_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/audit_log_test.go b/test/integration/audit_log_test.go index 639ea7a6780..3f9b2c39e0f 100644 --- a/test/integration/audit_log_test.go +++ b/test/integration/audit_log_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/authorizations_test.go b/test/integration/authorizations_test.go index d1f6224a7df..11043324ef4 100644 --- a/test/integration/authorizations_test.go +++ b/test/integration/authorizations_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/github_test.go b/test/integration/github_test.go index 5474724decf..abe0160635d 100644 --- a/test/integration/github_test.go +++ b/test/integration/github_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/issues_test.go b/test/integration/issues_test.go index c151ae482bd..9a5d95ca3bf 100644 --- a/test/integration/issues_test.go +++ b/test/integration/issues_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/misc_test.go b/test/integration/misc_test.go index 0e9ef6e01e7..3390666c57c 100644 --- a/test/integration/misc_test.go +++ b/test/integration/misc_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/pulls_test.go b/test/integration/pulls_test.go index c054f55d41e..8de93956135 100644 --- a/test/integration/pulls_test.go +++ b/test/integration/pulls_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/repos_test.go b/test/integration/repos_test.go index f33ab00f186..1c5e8359d96 100644 --- a/test/integration/repos_test.go +++ b/test/integration/repos_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration diff --git a/test/integration/users_test.go b/test/integration/users_test.go index aa2b9ba9be0..526700c819b 100644 --- a/test/integration/users_test.go +++ b/test/integration/users_test.go @@ -4,7 +4,6 @@ // license that can be found in the LICENSE file. //go:build integration -// +build integration package integration From a7e579232d3f2f676e07e2f55433d98a3b20466d Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Mon, 14 Oct 2024 13:07:46 +0300 Subject: [PATCH 2/2] Add minimum required Go version 1.17 to README --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 585790b7588..97e00cf1f97 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,8 @@ go-github is a Go client library for accessing the [GitHub API v3][]. -Currently, **go-github tests against Go version 1.22 and greater**. go-github tracks +**go-github requires Go version 1.17 and greater** and +the library is tested against Go version 1.22 and greater. go-github tracks [Go's version support policy][support-policy]. We do our best not to break older versions of Go if we don't have to, but due to tooling constraints, we don't always test older versions.