Skip to content

Conversation

@alexandear
Copy link
Contributor

This PR bumps golangci-lint to v2.6.1 and fixes modernize lint issues.

The omitzero check is not easy to fix, so I disabled it with the TODO comment.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (5953276) to head (f508f0d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
example/commitpr/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3817   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         192      192           
  Lines       13896    13896           
=======================================
  Hits        12823    12823           
  Misses        884      884           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis merged commit d47559a into google:master Nov 8, 2025
6 of 7 checks passed
@alexandear alexandear deleted the chore/enable-modernize branch November 8, 2025 20:47
elminster-aom pushed a commit to elminster-aom/go-github that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants