Skip to content

Conversation

@elminster-aom
Copy link
Contributor

@elminster-aom elminster-aom commented Dec 5, 2025

Related with #3813

From REST API endpoints for Enterprise SCIM docs, implements:

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.40%. Comparing base (bd1caa0) to head (f45301c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3858      +/-   ##
==========================================
+ Coverage   92.38%   92.40%   +0.01%     
==========================================
  Files         200      200              
  Lines       14360    14382      +22     
==========================================
+ Hits        13267    13289      +22     
  Misses        894      894              
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 5, 2025
@gmlewis gmlewis changed the title Implement Enterprise SCIM - Set Groups or Users feat: Implement Enterprise SCIM - Set Groups or Users Dec 5, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 8, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2025

@elminster-aom - please - no more operations on this PR. Once I say "Merging", I'm "taking over" the PR.
Now I have to wait because you clicked "Update".

@gmlewis gmlewis merged commit 6922e3b into google:master Dec 8, 2025
7 checks passed
@elminster-aom elminster-aom deleted the setEnterpriseSCIM branch December 8, 2025 20:25
@elminster-aom
Copy link
Contributor Author

no more operations on this PR. Once I say "Merging"

Sorry about that, my bad. I'll be more careful next time.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2025

Sorry about that, my bad. I'll be more careful next time.

No problem. I apologize... I was having a bit of a stressful morning and should have just kept quiet. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants