diff --git a/github/github.go b/github/github.go index 6f7938eaa4f..f092cc206c8 100644 --- a/github/github.go +++ b/github/github.go @@ -39,10 +39,15 @@ const ( HeaderRateUsed = "X-Ratelimit-Used" HeaderRequestID = "X-Github-Request-Id" - defaultAPIVersion = "2022-11-28" - defaultBaseURL = "https://api.github.com/" - defaultUserAgent = "go-github" + "/" + Version - uploadBaseURL = "https://uploads.github.com/" + // https://docs.github.com/en/rest/about-the-rest-api/api-versions#about-api-versioning + defaultAPIVersion = api20221128 + latestAPIVersion = api20260310 + api20221128 = "2022-11-28" + api20260310 = "2026-03-10" + + defaultBaseURL = "https://api.github.com/" + defaultUserAgent = "go-github" + "/" + Version + uploadBaseURL = "https://uploads.github.com/" headerAPIVersion = "X-Github-Api-Version" headerOTP = "X-Github-Otp" diff --git a/github/private_registries.go b/github/private_registries.go index 925a6783291..d1899f4f9a8 100644 --- a/github/private_registries.go +++ b/github/private_registries.go @@ -244,7 +244,7 @@ func (s *PrivateRegistriesService) ListOrganizationPrivateRegistries(ctx context return nil, nil, err } - req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion(api20260310)) if err != nil { return nil, nil, err } @@ -265,7 +265,7 @@ func (s *PrivateRegistriesService) ListOrganizationPrivateRegistries(ctx context func (s *PrivateRegistriesService) CreateOrganizationPrivateRegistry(ctx context.Context, org string, privateRegistry CreateOrganizationPrivateRegistry) (*PrivateRegistry, *Response, error) { u := fmt.Sprintf("orgs/%v/private-registries", org) - req, err := s.client.NewRequest(ctx, "POST", u, privateRegistry, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "POST", u, privateRegistry, WithVersion(api20260310)) if err != nil { return nil, nil, err } @@ -286,7 +286,7 @@ func (s *PrivateRegistriesService) CreateOrganizationPrivateRegistry(ctx context func (s *PrivateRegistriesService) GetOrganizationPrivateRegistriesPublicKey(ctx context.Context, org string) (*PublicKey, *Response, error) { u := fmt.Sprintf("orgs/%v/private-registries/public-key", org) - req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion(api20260310)) if err != nil { return nil, nil, err } @@ -308,7 +308,7 @@ func (s *PrivateRegistriesService) GetOrganizationPrivateRegistriesPublicKey(ctx func (s *PrivateRegistriesService) GetOrganizationPrivateRegistry(ctx context.Context, org, secretName string) (*PrivateRegistry, *Response, error) { u := fmt.Sprintf("orgs/%v/private-registries/%v", org, secretName) - req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "GET", u, nil, WithVersion(api20260310)) if err != nil { return nil, nil, err } @@ -331,7 +331,7 @@ func (s *PrivateRegistriesService) GetOrganizationPrivateRegistry(ctx context.Co func (s *PrivateRegistriesService) UpdateOrganizationPrivateRegistry(ctx context.Context, org, secretName string, privateRegistry UpdateOrganizationPrivateRegistry) (*Response, error) { u := fmt.Sprintf("orgs/%v/private-registries/%v", org, secretName) - req, err := s.client.NewRequest(ctx, "PATCH", u, privateRegistry, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "PATCH", u, privateRegistry, WithVersion(api20260310)) if err != nil { return nil, err } @@ -348,7 +348,7 @@ func (s *PrivateRegistriesService) UpdateOrganizationPrivateRegistry(ctx context func (s *PrivateRegistriesService) DeleteOrganizationPrivateRegistry(ctx context.Context, org, secretName string) (*Response, error) { u := fmt.Sprintf("orgs/%v/private-registries/%v", org, secretName) - req, err := s.client.NewRequest(ctx, "DELETE", u, nil, WithVersion("2026-03-10")) + req, err := s.client.NewRequest(ctx, "DELETE", u, nil, WithVersion(api20260310)) if err != nil { return nil, err } diff --git a/github/private_registries_test.go b/github/private_registries_test.go index 23f66a0e751..58cea11371b 100644 --- a/github/private_registries_test.go +++ b/github/private_registries_test.go @@ -21,7 +21,7 @@ func TestPrivateRegistriesService_ListOrganizationPrivateRegistries(t *testing.T mux.HandleFunc("/orgs/o/private-registries", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testFormValues(t, r, values{ "page": "2", }) @@ -101,7 +101,7 @@ func TestPrivateRegistriesService_CreateOrganizationPrivateRegistry(t *testing.T mux.HandleFunc("/orgs/o/private-registries", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "POST") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testJSONBody(t, r, input) w.WriteHeader(http.StatusCreated) fmt.Fprint(w, `{ @@ -166,7 +166,7 @@ func TestPrivateRegistriesService_CreateOrganizationPrivateRegistry_OIDC(t *test mux.HandleFunc("/orgs/o/private-registries", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "POST") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testJSONBody(t, r, input) w.WriteHeader(http.StatusCreated) fmt.Fprint(w, `{ @@ -215,7 +215,7 @@ func TestPrivateRegistries_UpdateOrganizationPrivateRegistry_OIDC(t *testing.T) mux.HandleFunc("/orgs/o/private-registries/AWS_REGISTRY_SECRET", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "PATCH") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testJSONBody(t, r, input) w.WriteHeader(http.StatusNoContent) }) @@ -243,7 +243,7 @@ func TestPrivateRegistriesService_CreateOrganizationPrivateRegistry_OIDCJFrog(t mux.HandleFunc("/orgs/o/private-registries", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "POST") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testJSONBody(t, r, input) w.WriteHeader(http.StatusCreated) fmt.Fprint(w, `{ @@ -279,7 +279,7 @@ func TestPrivateRegistriesService_GetOrganizationPrivateRegistriesPublicKey(t *t mux.HandleFunc("/orgs/o/private-registries/public-key", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) fmt.Fprint(w, `{ "key_id": "0123456789", "key": "public_key" @@ -320,7 +320,7 @@ func TestPrivateRegistriesService_GetOrganizationPrivateRegistry(t *testing.T) { mux.HandleFunc("/orgs/o/private-registries/MAVEN_REPOSITORY_SECRET", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) fmt.Fprint(w, `{ "name": "MAVEN_REPOSITORY_SECRET", "registry_type": "maven_repository", @@ -375,7 +375,7 @@ func TestPrivateRegistries_UpdateOrganizationPrivateRegistry(t *testing.T) { mux.HandleFunc("/orgs/o/private-registries/MAVEN_REPOSITORY_SECRET", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "PATCH") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) testJSONBody(t, r, input) w.WriteHeader(http.StatusNoContent) }) @@ -403,7 +403,7 @@ func TestPrivateRegistriesService_DeleteOrganizationPrivateRegistry(t *testing.T mux.HandleFunc("/orgs/o/private-registries/MAVEN_REPOSITORY_SECRET", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "DELETE") - testHeader(t, r, "X-Github-Api-Version", "2026-03-10") + testHeader(t, r, "X-Github-Api-Version", api20260310) w.WriteHeader(http.StatusNoContent) }) ctx := t.Context()