New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples to the README #810

Merged
merged 4 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@kshitij10496
Collaborator

kshitij10496 commented Dec 14, 2017

The modifications performed in this commit:

  1. A working code snippet has been added to the README
  2. The "examples" folder has been explicitly hyperlinked

Resolves #809

Added examples to the README
The modifications performed in this commit:
1.    A working code snippet has been added to the README
2.    The "examples" folder has been explicitly hyperlinked

Resolves #809
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
@kshitij10496

This comment has been minimized.

Show comment
Hide comment
@kshitij10496

kshitij10496 Dec 22, 2017

Collaborator

@shurcooL Does this look better now?

Collaborator

kshitij10496 commented Dec 22, 2017

@shurcooL Does this look better now?

@dmitshur

Indeed it does! I've left further comments inline.

Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated example/simple/main.go Outdated
Show outdated Hide outdated example/simple/main.go Outdated
Show outdated Hide outdated example/simple/main.go Outdated
@kshitij10496

This comment has been minimized.

Show comment
Hide comment
@kshitij10496

kshitij10496 Jan 2, 2018

Collaborator

@shurcooL Can you give this another review?

Collaborator

kshitij10496 commented Jan 2, 2018

@shurcooL Can you give this another review?

@dmitshur

Sorry about the delay.

This looks very reasonable now! I've suggested additional changes, and I think that's mostly it from me.

Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated example/simple/main.go Outdated

@dmitshur dmitshur requested a review from gmlewis Jan 9, 2018

@gmlewis

gmlewis approved these changes Jan 9, 2018

Thank you, @kshitij10496 and @shurcooL!
LGTM after you address @shurcooL's feedback and one tiny nit of mine.

Show outdated Hide outdated example/simple/main.go Outdated
@kshitij10496

This comment has been minimized.

Show comment
Hide comment
@kshitij10496

kshitij10496 Jan 10, 2018

Collaborator

Thanks, @shurcooL, and @gmlewis for the review.
I have tried to address your suggestions in the last commit.

Collaborator

kshitij10496 commented Jan 10, 2018

Thanks, @shurcooL, and @gmlewis for the review.
I have tried to address your suggestions in the last commit.

@gmlewis

This comment has been minimized.

Show comment
Hide comment
@gmlewis

gmlewis Feb 23, 2018

Collaborator

Sorry for the delay... Merging.

Collaborator

gmlewis commented Feb 23, 2018

Sorry for the delay... Merging.

@gmlewis gmlewis merged commit 293f4dd into google:master Feb 23, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment