New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a report collector plugin which can be used to generate a collector handler. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kele
requested changes
Aug 19, 2020
kele
approved these changes
Aug 20, 2020
mattiasgrenfeldt
force-pushed
the
grenfeldt-reports-collector-first-version
branch
from
August 20, 2020 12:36
3a88826
to
91b9626
Compare
Rebased on top of master so that tests don't fail |
maramihali
suggested changes
Aug 24, 2020
empijei
suggested changes
Aug 24, 2020
This has now changed quite a bit to accommodate reports with |
maramihali
suggested changes
Aug 28, 2020
mattiasgrenfeldt
force-pushed
the
grenfeldt-reports-collector-first-version
branch
from
August 28, 2020 11:59
a7454a9
to
1c121cb
Compare
kele
reviewed
Aug 29, 2020
Please rebase and I can merge. |
mattiasgrenfeldt
force-pushed
the
grenfeldt-reports-collector-first-version
branch
from
September 1, 2020 10:53
1c121cb
to
94083a3
Compare
Done! @kele |
mattiasgrenfeldt
force-pushed
the
grenfeldt-reports-collector-first-version
branch
2 times, most recently
from
September 2, 2020 11:28
9720583
to
0a10330
Compare
Done! @kele |
empijei
suggested changes
Sep 2, 2020
It can be used to create a reports collector handler for CSP reports. The user can provide a collector object which will be called with each incoming report.
… new generic reports Users are able two register two different handlers for old style CSP reports with Content-Type application/csp-report and new style generic reports with Content-Type application/reports+json. The new style reports could also contain CSPReports if the CSP is written using the report-to directive and not the report-uri directive.
…arshalling report
mattiasgrenfeldt
force-pushed
the
grenfeldt-reports-collector-first-version
branch
from
September 2, 2020 14:42
0a10330
to
9953ab6
Compare
mattiasgrenfeldt
deleted the
grenfeldt-reports-collector-first-version
branch
September 3, 2020 06:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be used to create a reports collector handler for CSP reports. The user can provide a collector object which will be called with each incoming report.
Fixes #75