Skip to content
This repository has been archived by the owner. It is now read-only.

Fixed 'exp' handling in ID token #58

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@sungjungk
Copy link
Contributor

commented Aug 10, 2018

It is a measure for issue #57.

Modification:
Change the way of ‘exp’ handling; from data.GetString(“exp”, &str_value) to data.GetScalar(“exp”, &int_value)

Result:
It will not happen the bug when receiving ID token value.

@googlebot

This comment has been minimized.

Copy link

commented Aug 10, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@sungjungk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Aug 10, 2018

CLAs look good, thanks!

@sungjungk

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@SurferJeffAtGoogle Could you check the issue?

@SurferJeffAtGoogle SurferJeffAtGoogle merged commit 3eeb584 into google:master Apr 10, 2019

1 check passed

cla/google All necessary CLAs are signed
@SurferJeffAtGoogle

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Thank you for submitting this fix. I apologize for taking so long to review. It got lost my TODO list. 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.