Fix up race between NSThread setName and pthread_getname on the thread. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
approved these changes
Nov 19, 2018
thomasvl
reviewed
Nov 19, 2018
| // If we run our "check" block too soon, we will check the value on the | ||
| // thread before it's been set. | ||
| // Therefore we loop over it with some sleep to give the thread a chance | ||
| // to update it's internals. | ||
| [workerThread_ gtm_performWaitingUntilDone:YES block:^{ | ||
| XCTAssertEqualObjects([workerThread_ name], testName); |
There was a problem hiding this comment.
Actually, shouldn't this have come out? Otherwise the it can still fail even though the code below lets it sleep and eventually take effect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.