New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching adding support for FreeBSD 10 #463

Closed
GoogleCodeExporter opened this Issue Jul 28, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@GoogleCodeExporter
Contributor

GoogleCodeExporter commented Jul 28, 2015

Please find attached a patch adding build support for FreeBSD 10. It basically 
turns on Linux build with clone disabled, with the addition of a few headers 
POSIX requires and Linux is sloppy about.

Original issue reported on code.google.com by niall.do...@maidsafe.net on 29 May 2014 at 4:14

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Jul 28, 2015

Contributor
Defining GTEST_OS_LINUX for FreeBSD doesn't sound right.
It's more work, but can we define a GTEST_OS_FBSD ?

Original comment by billydon...@google.com on 29 May 2014 at 4:25

Contributor

GoogleCodeExporter commented Jul 28, 2015

Defining GTEST_OS_LINUX for FreeBSD doesn't sound right.
It's more work, but can we define a GTEST_OS_FBSD ?

Original comment by billydon...@google.com on 29 May 2014 at 4:25

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Jul 28, 2015

Contributor
There is a GTEST_OS_OPENBSD in HEAD, but it isn't patched in everywhere 
GTEST_OS_LINUX is used and that wasn't enough for my use case because lots of 
functionality remains disabled.

Someone ought to go through and fix up a GTEST_OS_POSIX really, but it won't be 
me.

Original comment by niall.do...@maidsafe.net on 29 May 2014 at 4:41

Contributor

GoogleCodeExporter commented Jul 28, 2015

There is a GTEST_OS_OPENBSD in HEAD, but it isn't patched in everywhere 
GTEST_OS_LINUX is used and that wasn't enough for my use case because lots of 
functionality remains disabled.

Someone ought to go through and fix up a GTEST_OS_POSIX really, but it won't be 
me.

Original comment by niall.do...@maidsafe.net on 29 May 2014 at 4:41

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Jul 28, 2015

Contributor
Ed Maste has put a potential patch for FreeBSD support at 
https://codereview.appspot.com/178420043/

Original comment by drysd...@google.com on 1 Dec 2014 at 9:50

Contributor

GoogleCodeExporter commented Jul 28, 2015

Ed Maste has put a potential patch for FreeBSD support at 
https://codereview.appspot.com/178420043/

Original comment by drysd...@google.com on 1 Dec 2014 at 9:50

@emaste

This comment has been minimized.

Show comment
Hide comment
@emaste

emaste Jan 5, 2017

This issue should be closed. FreeBSD support was added in b215e30

emaste commented Jan 5, 2017

This issue should be closed. FreeBSD support was added in b215e30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment