New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googlemock: Disable WhenDynamicCastToTest tests when RTTI is off #612

Merged
merged 1 commit into from Nov 10, 2015

Conversation

Projects
None yet
2 participants
@markmentovai
Copy link
Contributor

markmentovai commented Oct 12, 2015

BillyDonahue added a commit that referenced this pull request Nov 10, 2015

Merge pull request #612 from mark-chromium/gmock_rtti
googlemock: Disable WhenDynamicCastToTest tests when RTTI is off

@BillyDonahue BillyDonahue merged commit 71a26ac into google:master Nov 10, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

dneto0 added a commit to dneto0/SPIRV-Tools that referenced this pull request Dec 1, 2015

Don't add -frtti for tests. Use newer googletest.
Using -frtti caused link failures when both of the following are
in effect:
	-DDISABLE_EXCEPTIONS=ON
	-DDISABLE_RTTI=ON

The correct fix is to use tip-of-tree googletest.
Specifically, we need a version of googletest with the fix in
google/googletest#612
In particular, it must be later than googletest 1.7.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment