New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register decodeDot11 for LinkTypeMetadata #302

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
3 participants
@Hjdskes
Contributor

Hjdskes commented Mar 19, 2017

In a (private) project of mine I have this code:

	dot11Layer := packet.Layer(layers.LayerTypeDot11)
	if dot11Layer == nil {
		return
	}

	dot11 := &layers.Dot11{}
	data := dot11Layer.LayerPayload()
	dot11.DecodeFromBytes(data, gopacket.NilDecodeFeedback)

which failed to decode properly: Packet decoding error: Unable to decode link type 105. This change fixes that issue.

If the issue is a result of a mistake on my side and this commit is the wrong way around it, please do tell me.

@googlebot

This comment has been minimized.

Collaborator

googlebot commented Mar 19, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@Hjdskes

This comment has been minimized.

Contributor

Hjdskes commented Mar 19, 2017

I signed it!

@googlebot

This comment has been minimized.

Collaborator

googlebot commented Mar 19, 2017

CLAs look good, thanks!

@gconnell gconnell merged commit f10e8ef into google:master May 23, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment