New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert LLC and SNAP to DecodingLayer interface #505

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@notti
Collaborator

notti commented Aug 30, 2018

This moves code from the decodeX functions to DecodeFromBytes for both LLC and SNAP and changes decodeX to use DecodeFromBytes. The only behavioral change I introduced is error handling in case the passed byte-slice is too short.

Since I touched the file, I also added a second commit that removes the underscores in LLC.SerializeTo from the variable names to make the linter happy - I can make a separate pull request for this if you like.

@notti

This comment has been minimized.

Collaborator

notti commented Aug 30, 2018

Oh from the travis log I just saw, that llc.go is on the linter blacklist - after this it should be possible to take it off this blacklist.

@gconnell gconnell merged commit 26846a8 into google:master Aug 30, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment